Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 11, 2012, 17:16 UTC
Message-ID: <CAMP44s1pWm_n-SwB5Bi8UxM-oRG=4dGXq7jVKx_E1rcoRaXaHw@mail.gmail.com>
In-Reply-To: <509FD9BC.7050204@gmail.com>

On Sun, Nov 11, 2012 at 6:00 PM, A Large Angry SCM <gitzilla@gmail.com> wrote:

> On 11/11/2012 07:41 AM, Felipe Contreras wrote:

Show 9 quoted lines

>> Such a filter would probably be quite complicated, and would decrease
>> performance.
>
> Really?
>
> The fast import stream protocol is pretty simple. All the filter really
> needs to do is pass through everything that isn't a 'commit' command. And
> for the 'commit' command, it only needs to do something with the 'author'
> and 'committer' lines; passing through everything else.

And how do you propose to find the commit commands without parsing all the other commands? If you randomly look for lines that begin with 'commit /refs' you might end up in the middle of a commit message or the contents of a file.

> I agree that an additional filter _may_ decrease performance somewhat if you
> are already CPU constrained. But I suspect that the effect would be
> negligible compared to the all of the SHA-1 calculations.

Well. If it's so easy surely you can write one quickly, and I can measure it.

Cheers.

-- 
Felipe Contreras