Re: [PATCH] test-lib: avoid full path to store test results

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Oct 30, 2012, 04:39 UTC
Message-ID: <CAMP44s2a40Bx2X3QfbtCZFDR71W5puadfpSRQSy9kjbkm_f-sA@mail.gmail.com>
In-Reply-To: <20121030042850.GA23263@sigill.intra.peff.net>

On Tue, Oct 30, 2012 at 5:28 AM, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> On Tue, Oct 30, 2012 at 05:12:57AM +0100, Felipe Contreras wrote:
>
>> No reason to use the full path in case this is used externally.
>
> I think it is not just "no reason to", but it is actively wrong to use a
> full path, as we do not take care to "mkdir -p" the intervening path
> components.
>
> However, this never comes up in practice, because all of the test
> scripts assume you are running them from the test directory (i.e.,
> they will fail otherwise because they will not find ./test-lib.sh).
>
> Is this in support of putting remote-hg tests in contrib/? I had
> expected you to just put
>
>   export TEST_DIRECTORY="$(pwd)/../../../t"
>   . "$TEST_DIRECTORY/test-lib.sh"

If there was a single script and we didn't want reports, sure, but this is not too bad:

TESTS := $(wildcard test*.sh)

export T := $(addprefix $(CURDIR)/,$(TESTS)) export MAKE := $(MAKE) -e export PATH := $(CURDIR):$(PATH)

test:
	$(MAKE) -C ../../t $@

$(TESTS):
	$(MAKE) -C ../../t $(CURDIR)/$@

.PHONY: $(TESTS)

I just sent the new remote-hg patch series with that.

Cheers.

-- 
Felipe Contreras