git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib: avoid full path to store test results

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Oct 30, 2012, 07:01 UTC
Message-ID
<20121030070152.GA13324@elie.Belkin>
In-Reply-To
<CA+EOSB=Rr8czjVJfA+F6DmHjDUBy0QQ-wd4t-3Uwb1Ksoadr0Q@mail.gmail.com>
Elia Pinto wrote:
> The shell word splitting done in base is a bashism, iow not portable.

No, ${varname##glob} is in POSIX and we already use it here and there. See Documentation/CodingGuidelines:

   - We use ${parameter#word} and its [#%] siblings, and their
     doubled "longest matching" form.

Thanks for looking the patch over. Jonathan

Previous: Elia PintoNext: Elia Pinto
Message 16 of 18 in “test-lib: avoid full path to store test results”
  1. test-lib: avoid full path to store test resultsFelipe Contreras, Oct 30, 2012
  2. Jeff KingOct 30, 2012
  3. Felipe ContrerasOct 30, 2012
  4. Jonathan NiederOct 30, 2012
  5. Felipe ContrerasOct 30, 2012
  6. Jonathan NiederOct 31, 2012
  7. Felipe ContrerasOct 31, 2012
  8. Jonathan NiederOct 31, 2012
  9. Felipe ContrerasOct 31, 2012
  10. Johannes SixtOct 31, 2012
  11. Felipe ContrerasOct 31, 2012
  12. Jeff KingNov 2, 2012
  13. Felipe ContrerasNov 2, 2012
  14. Jeff KingNov 2, 2012
  15. Elia PintoOct 30, 2012
  16. Jonathan NiederOct 30, 2012
  17. Elia PintoOct 30, 2012
  18. Stefano LattariniOct 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.