git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_name: reorganize get_sha1_basic()

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 2, 2013, 00:53 UTC
Message-ID
<CAMP44s2_riedK8gsHELRgQXd+7XWaTC6ErhPqX3xqWQoc5pJKQ@mail.gmail.com>
In-Reply-To
<1367455791-30091-1-git-send-email-felipe.contreras@gmail.com>

On Wed, May 1, 2013 at 7:49 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 12 quoted lines
> Through the years the functionality to handle @{-N} and @{u} has moved
> around the code, and as a result, code that once made sense, doesn't any
> more.
>
> There is no need to call this function recursively with the branch of
> @{-N} substituted because dwim_{ref,log} already replaces it.
>
> However, there's one corner-case where @{-N} resolves to a detached
> HEAD, in which case we wouldn't get any ref back.
>
> So we parse the nth-prior manually, and deal with it depending on
> weather it's a SHA-1, or a ref.
Forgot to mention; inspired by a patch from Ramkumar Ramachandra.
-- 
Felipe Contreras
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 6 in “sha1_name: reorganize get_sha1_basic()”
  1. sha1_name: reorganize get_sha1_basic()Felipe Contreras, May 2, 2013
  2. Felipe ContrerasMay 2, 2013
  3. Felipe ContrerasMay 2, 2013
  4. Ramkumar RamachandraMay 2, 2013
  5. Duy NguyenMay 2, 2013
  6. Felipe ContrerasMay 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.