From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 02 May 2013 00:53:41 GMT
Subject: Re: [PATCH] sha1_name: reorganize get_sha1_basic()
Message-ID: <CAMP44s2_riedK8gsHELRgQXd+7XWaTC6ErhPqX3xqWQoc5pJKQ@mail.gmail.com>
In-Reply-To: <1367455791-30091-1-git-send-email-felipe.contreras@gmail.com>

On Wed, May 1, 2013 at 7:49 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Through the years the functionality to handle @{-N} and @{u} has moved
> around the code, and as a result, code that once made sense, doesn't any
> more.
>
> There is no need to call this function recursively with the branch of
> @{-N} substituted because dwim_{ref,log} already replaces it.
>
> However, there's one corner-case where @{-N} resolves to a detached
> HEAD, in which case we wouldn't get any ref back.
>
> So we parse the nth-prior manually, and deal with it depending on
> weather it's a SHA-1, or a ref.

Forgot to mention; inspired by a patch from Ramkumar Ramachandra.

-- 
Felipe Contreras