Re: [PATCH v3] build: add default aliases

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 24, 2013, 05:32 UTC
Message-ID: <CAMP44s1tirA5w91L2YomaduZVkqL3=n1j79eoueB6XeGuyY3Mw@mail.gmail.com>
In-Reply-To: <20130924045325.GD2766@sigill.intra.peff.net>

On Mon, Sep 23, 2013 at 11:53 PM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

> On Sat, Sep 21, 2013 at 02:20:21PM -0500, Felipe Contreras wrote:
>
>> For now simply add a few common aliases.
>>
>>   co = checkout
>>   ci = commit
>>   rb = rebase
>>   st = status
>
> Are these the best definitions of those shortcuts? It seems[1] that some
> people define "ci" as "commit -a", and some people define "st" as
> "status -s" or even "status -sb".
>
> You are making things more consistent for people who already define
> those aliases in the same way (they are available everywhere, even if
> they have not moved their config to a new installation), but less so for
> people who define them differently. Rather than get an obvious:
>
>   git: 'co' is not a git command. See 'git --help'.
>
> the result will be subtly different (especially so in the case of
> "commit" versus "commit -a").

Before:

# machine A: git ci git: 'ca' is not a git command. See 'git --help'.

# machine B: git ci commits

After:

# machine A: git ci no changes added to commit (use "git add" and/or "git commit -a")

# machine B: git ci commits

The "after" part is much more consistent, at least several commands have a higher chance of doing what the user actually wants, at worst they would do something close to what the user wants.

-- 
Felipe Contreras