Re: [PATCH] Add project-wide .vimrc configuration

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Dec 9, 2020, 06:20 UTC
Message-ID: <CAMP44s1fNwC+AfnPJxhG=24Zt5NFE5SoZZXpGEb-jcc+3QSg9A@mail.gmail.com>
In-Reply-To: <X9ApG0jUxJrPDK9d@generichostname>

On Tue, Dec 8, 2020 at 7:32 PM Denton Liu <liu.denton@gmail.com> wrote:

> On Tue, Dec 08, 2020 at 06:26:19PM -0600, Felipe Contreras wrote:

Show 19 quoted lines

> > diff --git a/.vimrc b/.vimrc
> > new file mode 100644
> > index 0000000000..d250ab26e0
> > --- /dev/null
> > +++ b/.vimrc
> > @@ -0,0 +1,9 @@
> > +augroup git
> > +  au!
> > +  au BufRead,BufNewFile */t/*.sh set ft=sharness.sh
> > +  au BufRead,BufNewFile */Documentation/*.txt set ft=asciidoc
> > +
> > +  au FileType c setl noet ts=8 sw=0 cino=(s,:0,l1,t0
> > +  au FileType sh setl noet ts=8 sw=0
> > +  au FileType asciidoc setl noet ts=8 sw=0 autoindent
> > +augroup END
>
> A couple of nits. We should tab-indent this file since the rest of the
> project uses tabs everywhere. Also, perhaps use the full name for the
> option names so that it's immediately obvious what each setting does?

All right, makes sense to me.

-- 
Felipe Contreras