Re: [PATCH 4/4] fast-import: only store commit objects

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 3, 2013, 18:23 UTC
Message-ID: <CAMP44s1R9hAMZ=DQoPiTVi3+40NpADjVFU7tYovZA8W-PWEhhg@mail.gmail.com>
In-Reply-To: <87y5bw3q1s.fsf@hexa.v.cablecom.net>

On Fri, May 3, 2013 at 12:56 PM, Thomas Rast <trast@inf.ethz.ch> wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 6 quoted lines

> How do we know that this doesn't break any users of fast-import?  Your
> comment isn't very reassuring:
>
>> the vast majority of them will never be used again
>
> So what's with the minority?

Actually I don't think there's any minority. If the client program doesn't store blobs, the blob marks are not used anyway. So there's no change.

However, there's a chance the client programs do rely on blob objects, in which case things would break. I would like to analyze some client programs of fast-import out there, to see what would be the impact.

But I think this has to be done either way, the only question is how. Having a warning would take a lot of effort, and it might be for nothing. I think it might make sense to knowingly make the potentially dangerous change, and see what breaks. Most likely nothing will, but if something does, we revert immediately.

Otherwise we would be stuck in this non-ideal state forever.

Cheers.

-- 
Felipe Contreras