Re: [PATCH 3/4] fast-export: don't parse all the commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 4, 2013, 19:22 UTC
- Message-ID
- <7vli7uwnws.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAMP44s09KqFuXPf=3qG42jzChnNBoiXdStME6Ga7EzY7uwF88Q@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 12 quoted lines
>> This updates the parse_object() moved by the previous patch. At this >> point in the codeflow, unlike the original, we already _know_ the >> object must be a commit; wouldn't an equivalent of: >> >> object = &(lookup_commit(sha1)->object) >> >> be more correct here? > > Maybe, if we want to run some extra code we don't care about. > > The only actual difference is that object->type will be OBJ_COMMIT, > ...
The reason to prefer lookup_commit() over lookup_unknown_object() is primarily that we allocate the storage for known type, not union, out of the allocation pool (alloc.c) for the known type. Also we mark the result with the type so that we can catch mistakes in data when later code somehow expects an object with the same object name to be of different type; while the latter is a good safety measure, I do not think it matters that much in this codepath. The former is more important in general.