Re: [PATCH v3 4/4] fast-export: make sure refs are updated properly

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 2, 2012, 15:35 UTC
Message-ID: <CAMP44s1QPNCASyz3sVHPkJGv+PqrV5_Rt1ymVavupkaCtr-DJQ@mail.gmail.com>
In-Reply-To: <20121102151955.GA24622@sigill.intra.peff.net>

On Fri, Nov 2, 2012 at 4:19 PM, Jeff King <peff@peff.net> wrote:

> On Fri, Nov 02, 2012 at 04:17:14PM +0100, Johannes Schindelin wrote:

Show 17 quoted lines

>> May I just ask to include a summary of that rationale into the commit
>> message rather than relying on people having internet access and knowing
>> where to look? Adding the following to the commit message would be good
>> enough for me:
>>
>>       Note that
>>
>>               $ git branch foo master~1
>>               $ git fast-export foo master~1..master
>>
>>       still does not update the "foo" ref, but a partial fix is better
>>       than no fix.
>
> Yes, I think that makes a lot of sense.
>
> Felipe, I notice that you sent out a big "fast-export improvements"
> series. Does that supersede this?

Yes. I noticed this patch fixes other tests.

Cheers.

-- 
Felipe Contreras