git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/4] fast-export: fix comparisson in tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 30, 2012, 19:06 UTC
Message-ID
<1351623987-21012-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1351623987-21012-1-git-send-email-felipe.contreras@gmail.com>

First the expected, then the actual, otherwise the diff would be the opposite of what we want.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9350-fast-export.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
index 3e821f9..49bdb44 100755
--- a/t/t9350-fast-export.sh
+++ b/t/t9350-fast-export.sh
@@ -303,7 +303,7 @@ test_expect_success 'dropping tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=drop mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -320,7 +320,7 @@ test_expect_success 'rewriting tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=rewrite mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -351,7 +351,7 @@ test_expect_failure 'no exact-ref revisions included' '
 	(
 		cd limit-by-paths &&
 		git fast-export master~2..master~1 > output &&
-		test_cmp output expected
+		test_cmp expected output
 	)
 '
 
-- 
1.8.0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 21 in “fast-export: general fixes”
  1. 0/4 fast-export: general fixesFelipe Contreras, Oct 30, 2012
  2. 1/4 fast-export: trivial cleanupFelipe Contreras, Oct 30, 2012
  3. 2/4 fast-export: fix comparisson in testsFelipe Contreras, Oct 30, 2012
  4. 3/4 fast-export: don't handle uninteresting refsFelipe Contreras, Oct 30, 2012
  5. 4/4 fast-export: make sure refs are updated properlyFelipe Contreras, Oct 30, 2012
  6. Jonathan NiederOct 31, 2012
  7. Felipe ContrerasOct 31, 2012
  8. Jonathan NiederOct 31, 2012
  9. Sverre RabbelierOct 31, 2012
  10. Jonathan NiederOct 31, 2012
  11. [OT] How to get the discussion details via notesPeter Baumann, Oct 31, 2012
  12. Drew NorthupOct 31, 2012
  13. Jeff KingOct 31, 2012
  14. Peter BaumannNov 1, 2012
  15. Felipe ContrerasOct 31, 2012
  16. Jeff KingNov 2, 2012
  17. Jonathan NiederNov 2, 2012
  18. Johannes SchindelinNov 2, 2012
  19. Jeff KingNov 2, 2012
  20. Felipe ContrerasNov 2, 2012
  21. Felipe ContrerasNov 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.