Re: [PATCH 2/3] fast-export: add new --refspec option
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 16, 2013, 09:15 UTC
- Message-ID
- <CAMP44s1G=SFJ-5J8UR=mnoO_JXmuY+CC1FaaY7yJNQGuCi0Naw@mail.gmail.com>
- In-Reply-To
- <7vk3n763is.fsf@alter.siamese.dyndns.org>
On Thu, May 9, 2013 at 8:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> It is a very powerful concept that we can generate data once, > cast it in stone, and delay the decision on _how_ it is used > until the last minute, much better than mapping at export time. > So bundle does not need a similar refspec mechanism to map what > it exports. I haven't thought things through to see if the same > logic applies to fast-export output (if so, it would mean it is > better to allow the consumer of the stream take the refspec > parameter and map the tips it finds in its input), though.
It's possible to delay the renaming of refspecs to leave that duty to the remote-helper, however, each and every remote-helper would need advertise a new capability, and then implement the renaming. I think it makes much more sense to implement something that just works for free in all remote-helpers.
But I wasn't even that interested in this patch, I implemented it because while I was helping the emacs folks I had to explain to them that old:new didn't work, and I thought it would be trivial to make it work.
I'm dropping this series. Somebody should at least make it so a proper error is displayed so that the users are not left in the dark wondering what the hell is going on.
-- Felipe Contreras