Re: [PATCH 1/3] fast-export: improve argument parsing

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2013, 23:27 UTC
Message-ID: <7vy5bn68eu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s2RYPENwsPAcoaKjmHxkuVA52vvRrQ_stmT_qY-Pmt6HA@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 13 quoted lines

> On Thu, May 9, 2013 at 5:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> We don't want to pass arguments specific to fast-export to
>>> setup_revisions.
>>
>> Interesting.  What bad things happen with the current order?
>>
>> Does "fast-export --export-marks=foo" causes setup_revisions() to
>> mistakenly eat --export-marks=foo and barf?
>
> No, apparently it skips them. But try 'git fast-export --export-marks
> marks HEAD'.

That is the kind of thing that needs to be said, not in the discussion but in the history, either in the log or in a new test, or both.