Re: [PATCH] revision: add --except option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Aug 30, 2013, 18:37 UTC
Message-ID: <CAMP44s180h8OTXx0v7dp3WKO2=ZBF3h7nXp_CcomQFmFn1SHSw@mail.gmail.com>
In-Reply-To: <xmqqeh9b15x6.fsf@gitster.dls.corp.google.com>

On Fri, Aug 30, 2013 at 11:48 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Which means that the approach taken by the patch to only allow
> exclusion of negative ones makes the idea only 50% useful compared
> to its potential.  And I suspect that "we can start from 50% which
> is better than 0% and later fill the other 50%" would not work in
> this case, without ripping out the "SKIP on object" approach and
> redoing the "--except" support from scratch, because "SKIP on
> object" fundamentally cannot undo the effects of the negative ones,
> because it records the information at a wrong level.

I think it is not 50%, it is 98%. I think one or two persons might use this secondary feature if ever, and I think waiting for that implementation will delay the feature that 98% of people would use, and maybe block it entirely.

-- 
Felipe Contreras