Re: [PATCH 0/2] remote-helpers: test fixes

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 20, 2013, 23:22 UTC
Message-ID: <CAMP44s13hjYzqHuBHKjGXRbf6PTyOiX=_EeuwAdLdZ9wSo-oQQ@mail.gmail.com>
In-Reply-To: <7v7gits0r9.fsf@alter.siamese.dyndns.org>

On Mon, May 20, 2013 at 6:13 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Mon, May 20, 2013 at 5:47 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> Hi,
>>>>
>>>> I've setup a project in Travis CI for continuous integration with very good
>>>> results, however, I had to apply a couple of fixes.
>>>>
>>>> I'm not sure if this is v1.8.3 material, but here they are.
>>>
>>> Thanks; I'll queue them at the tip of fc/remote-hg to graduate soon
>>> after 1.8.3, then.
>>
>> No, they should be graduated first. The tip of fc/remote-hg is in pu,
>> no? I have rebased that branch and squashed some fixes so every commit
>> works on all versions of Mercurial. I will resend all the patches, the
>> only reason I haven't done so is that I didn't want to create more
>> noise before v1.8.3, and you said I was the one taking the decision
>> when to merge remote-helper stuff to master.
>
> Then is this v1.8.3 material?  Please do not stay "I'm not sure" for
> very long.  I do not think we want -rc4 only for a contrib/ stuff.

I think this could very well fit into v1.8.3, but there's no rush, it can wait until after.

> For today's integration run I didn't want to wait so tentatively
> they are queued at the tip of fc/remote-hg, and it is too late to
> redo everything I did today, but I can requeue them for 'master' in
> the tomorrow's cycle if you want.

I think 'next' is fine, they could go into 'master' to improve the testing of what's already there, but it probably won't matter much. Moreover, it's not fixing test regressions; the issues have been there pretty much since day one, and if nobody has found them by now it probably won't change anything for v1.8.3.

My main motivation is that with these patches I could test a pristine 'master' branch directly into travis-ci.

-- 
Felipe Contreras