Re: [PATCH v2 42/44] ruby: remove GIT_PAGER from environment

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 28, 2013, 23:33 UTC
Message-ID: <CAMP44s0v5tj=e1o0tze00OzRM1YNuMU9YaVvtav02Eoj8+O-nw@mail.gmail.com>
In-Reply-To: <524765DE.9030009@googlemail.com>

On Sat, Sep 28, 2013 at 6:27 PM, Stefan Beller <stefanbeller@googlemail.com> wrote:

Show 25 quoted lines

> On 09/29/2013 12:04 AM, Felipe Contreras wrote:
>> We are not calling any git commands any more.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>>  git-request-pull.rb | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/git-request-pull.rb b/git-request-pull.rb
>> index fde8d1a..941ff72 100755
>> --- a/git-request-pull.rb
>> +++ b/git-request-pull.rb
>> @@ -2,8 +2,6 @@
>>
>>  require 'date'
>>
>> -ENV['GIT_PAGER'] =
>> -
>>  patch = nil
>>
>>  def usage
>>
>
> Could this be squashed into the patch introducing the ENV?
> (I assume that patch is among the 44 patches?)

It could be, but when ENV['GIT_PAGER'] was introduced, there were 'git foo' commands being called, so they would get a different $GIT_PAGER if we do so, which would be a change from the original script.

To be honest I don't know what that code is trying to achieve, but to err on the side of caution I'm leaving the code close to the original.

-- 
Felipe Contreras