[PATCH v2 21/44] ruby: request-pull: use get_sha1()
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
Notes:
To minimize the changes in the rest of the script, the sha1 is converted by to
a hex. git-request-pull.rb | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/git-request-pull.rb b/git-request-pull.rb
index 25dc04d..9267147 100755
--- a/git-request-pull.rb
+++ b/git-request-pull.rb
@@ -92,11 +92,14 @@ end
tag_name = describe(head)
-baserev = `git rev-parse --verify --quiet "#{base}"^0`.chomp
-die "Not a valid revision: #{base}" if baserev.empty?
+baserev = get_sha1("#{base}^0")
+die "Not a valid revision: #{base}" unless baserev
-headrev = `git rev-parse --verify --quiet "#{head}"^0`.chomp
-die "Not a valid revision: #{head}" if headrev.empty?
+headrev = get_sha1("#{head}^0")
+die "Not a valid revision: #{head}" unless headrev
+
+baserev = sha1_to_hex(baserev)
+headrev = sha1_to_hex(headrev)
merge_base = `git merge-base #{baserev} #{headrev}`.chomp
die "No commits in common between #{base} and #{head}" unless $?.success?
--
1.8.4-fc
Felipe Contreras <felipe.contreras@gmail.com>