Re: [PATCH v2 4/4] completion: be nicer with zsh

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 30, 2012, 19:22 UTC
Message-ID: <CAMP44s0dU5zQLnen_DSONOum7P1UsPTASSkF1sJE2m7kAwx21A@mail.gmail.com>
In-Reply-To: <7vliopatxg.fsf@alter.siamese.dyndns.org>

2012/1/30 Junio C Hamano <gitster@pobox.com>:

Show 15 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>> Felipe Contreras wrote:
>> ..., so I suppose consistency is the only reason to
>> prefer one over another.
>
> Yes. And the script may probably use [[ very heavily.
>
> Early return after || i.e.
>
>        A || return
>        B
>
> simply looks ugly and misleading, especially when the remainder B is just
> a single line.  But I stopped caring about the styles in this particular
> script long time ago, so...

What would you rather use?

[ "$__git_merge_strategies" ] && __git_merge_strategies=$(__git_list_merge_strategies)

That's 90 characters long. Although much better without the 2>/dev/null.

if [ "$__git_merge_strategies" ]; then
  __git_merge_strategies=$(__git_list_merge_strategies)
fi

That's even more lines =/

-- 
Felipe Contreras