Re: [PATCH v2 4/4] completion: be nicer with zsh

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 30, 2012, 18:25 UTC
Message-ID: <20120130182547.GA22549@burratino>
In-Reply-To: <CAMP44s0ACC+AnwHGtBLe8C1S_sxWj6SbMbawDThvLQAA0pKMYQ@mail.gmail.com>

Felipe Contreras wrote:

> The commands might fail, that's why '2> /dev/null' was used before,
> and ':' is used right now.

Wait, what?

: is a no-op command. It does not redirect stderr automatically or do any other magical thing.

[...]

> And IMO harder to read. But you are correct that most of the code uses
> [[]], which I think is a shame. But I guess people want to keep using
> that.

[[ has simpler syntax wrt quoting and other details. But now that I check, the code uses [ a lot, too (which, like "test", is a plain built-in command), so I suppose consistency is the only reason to prefer one over another. "git log --grep='if \['" tells me the use of '[' instead of 'test' here is deliberate.