Re: [PATCH] fast-import: do not truncate exported marks file

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 18, 2016, 04:03 UTC
Message-ID: <CAMP44s06+V8_PvYA=wsqZ625hrMPLKuZ6v5eOmLBO97kTqwxvw@mail.gmail.com>
In-Reply-To: <CAPc5daVJCfnEfA1sHrAGsXaA-80kFV4_4Hd0tLOMocE+qVV=-Q@mail.gmail.com>

On Tue, May 17, 2016 at 10:59 PM, Junio C Hamano <gitster@pobox.com> wrote:

> On Tue, May 17, 2016 at 8:31 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> On Tue, May 17, 2016 at 5:22 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

>>>  - Even if we did not read from any existing marks file, if we are
>>>    given export_marks_file that names an existing file, wouldn't we
>>>    want to avoid corrupting it with a dump from this aborted run?
>>
>> If we don't run from an existing marks file, this patch has no effect.
>
> Yes, that is exactly what I was wondering if we may want to improve
> while at it.

This doesn't make much sense. Corrupted from where? This patch is tackling the issue where the imported marks file is "corrupted".

-- 
Felipe Contreras