From: Felipe Contreras Date: Wed, 18 May 2016 04:03:41 GMT Subject: Re: [PATCH] fast-import: do not truncate exported marks file Message-ID: In-Reply-To: On Tue, May 17, 2016 at 10:59 PM, Junio C Hamano wrote: > On Tue, May 17, 2016 at 8:31 PM, Felipe Contreras > wrote: >> On Tue, May 17, 2016 at 5:22 PM, Junio C Hamano wrote: >>> - Even if we did not read from any existing marks file, if we are >>> given export_marks_file that names an existing file, wouldn't we >>> want to avoid corrupting it with a dump from this aborted run? >> >> If we don't run from an existing marks file, this patch has no effect. > > Yes, that is exactly what I was wondering if we may want to improve > while at it. This doesn't make much sense. Corrupted from where? This patch is tackling the issue where the imported marks file is "corrupted". -- Felipe Contreras