git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] rebase: stop accepting --rebase-merges=""

From
Alex Henrie <alexhenrie24@gmail.com>
Date
Feb 23, 2023, 05:35 UTC
Message-ID
<CAMMLpeTsg6kRxun84YS_PwBkdUHPV=6St1KCavz-zcw+kZWzUQ@mail.gmail.com>
In-Reply-To
<xmqqlekpb6f3.fsf@gitster.g>
On Wed, Feb 22, 2023 at 4:56 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
>
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > +test_expect_success '--rebase-merges="" is invalid syntax' '
> > +     echo "fatal: Unknown mode: " >expect &&
> > +     ! git rebase --rebase-merges="" HEAD^ 2>actual &&
>
> "!" takes any non-zero exit, even a segfaulting "git".  Let's use
> test_must_fail to make sure it dies in a controlled way, i.e.
>
>         test_must_fail git rebase --rebase-merges="" HEAD^ 2>actual &&
Done in v4. Thanks for the feedback.
-Alex
Previous: Junio C HamanoNext: Alex Henrie
Message 4 of 6 in “rebase: add documentation and tests for --no-rebase-merges”
  1. 1/3 rebase: add documentation and tests for --no-rebase-mergesAlex Henrie, Feb 22, 2023
  2. 2/3 rebase: stop accepting --rebase-merges=""Alex Henrie, Feb 22, 2023
  3. Junio C HamanoFeb 22, 2023
  4. Alex HenrieFeb 23, 2023
  5. 3/3 rebase: add a config option for --rebase-mergesAlex Henrie, Feb 22, 2023
  6. Junio C HamanoFeb 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.