From: Alex Henrie <alexhenrie24@gmail.com>
Date: Thu, 23 Feb 2023 05:35:39 GMT
Subject: Re: [PATCH v3 2/3] rebase: stop accepting --rebase-merges=""
Message-ID: <CAMMLpeTsg6kRxun84YS_PwBkdUHPV=6St1KCavz-zcw+kZWzUQ@mail.gmail.com>
In-Reply-To: <xmqqlekpb6f3.fsf@gitster.g>

On Wed, Feb 22, 2023 at 4:56 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > +test_expect_success '--rebase-merges="" is invalid syntax' '
> > +     echo "fatal: Unknown mode: " >expect &&
> > +     ! git rebase --rebase-merges="" HEAD^ 2>actual &&
>
> "!" takes any non-zero exit, even a segfaulting "git".  Let's use
> test_must_fail to make sure it dies in a controlled way, i.e.
>
>         test_must_fail git rebase --rebase-merges="" HEAD^ 2>actual &&

Done in v4. Thanks for the feedback.

-Alex