git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: improve grammar of "shallow roots" message

From
Alex Henrie <alexhenrie24@gmail.com>
Date
May 20, 2021, 04:02 UTC
Message-ID
<CAMMLpeRxoakadrXUVGSkhP0K71GHXxt4sXvSKrB5rx8oFH60bw@mail.gmail.com>
In-Reply-To
<626174ae-ff25-8f07-4d67-705bbe3f7d68@gmail.com>
On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
Show 7 quoted lines
>
> On 18/05/21 13.18, Alex Henrie wrote:
>
> > -                                     warning(_("reject %s because shallow roots are not allowed to be updated"),
> > +                                     warning(_("rejected %s because shallow roots are not allowed to be updated"),
>
>  From descriptive to null-subject past tense, right?

I'm not sure what the best way is to describe the grammar here. I would say that the "ed" makes it clear that the message is a description of what did happen rather than an imperative command concerning what should happen.

-Alex
Previous: Bagas SanjayaNext: Bagas Sanjaya
Message 5 of 6 in “fetch: improve grammar of "shallow roots" message”
  1. fetch: improve grammar of "shallow roots" messageAlex Henrie, May 18, 2021
  2. Junio C HamanoMay 19, 2021
  3. Derrick StoleeMay 19, 2021
  4. Bagas SanjayaMay 20, 2021
  5. Alex HenrieMay 20, 2021
  6. Bagas SanjayaMay 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.