From: Alex Henrie <alexhenrie24@gmail.com>
Date: Thu, 20 May 2021 04:02:24 GMT
Subject: Re: [PATCH] fetch: improve grammar of "shallow roots" message
Message-ID: <CAMMLpeRxoakadrXUVGSkhP0K71GHXxt4sXvSKrB5rx8oFH60bw@mail.gmail.com>
In-Reply-To: <626174ae-ff25-8f07-4d67-705bbe3f7d68@gmail.com>

On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 18/05/21 13.18, Alex Henrie wrote:
>
> > -                                     warning(_("reject %s because shallow roots are not allowed to be updated"),
> > +                                     warning(_("rejected %s because shallow roots are not allowed to be updated"),
>
>  From descriptive to null-subject past tense, right?

I'm not sure what the best way is to describe the grammar here. I
would say that the "ed" makes it clear that the message is a
description of what did happen rather than an imperative command
concerning what should happen.

-Alex