Re: [PATCHv5 2/2] Documentation/clone: document ignored configuration variables

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jun 16, 2017, 22:15 UTC
Message-ID: <CAM0VKjm0MY-DrOX+LuPqvk1L5od3g+SFA_k6dh0QT7ZT7HSh-A@mail.gmail.com>
In-Reply-To: <87vanv8wq4.fsf@gmail.com>

On Fri, Jun 16, 2017 at 11:10 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 12 quoted lines

>     diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt
>     index 35cc34b2fb..2169e5c97f 100644
>     --- a/Documentation/git-clone.txt
>     +++ b/Documentation/git-clone.txt
>     @@ -189,6 +189,14 @@ objects from the source repository into a pack in the cloned repository.
>             values are given for the same key, each value will be written to
>             the config file. This makes it safe, for example, to add
>             additional fetch refspecs to the origin remote.
>     ++
>     +The underlying implementation of `git clone` isn't equivalent to `git
>     +init` followed by a `git fetch`, but the two share some of the
>     +underlying fetch machinery.

I think this is unnecessarily technical and detailed to be included under the docs of the '--config' option.

> Because of this, setting configuration
>     +variables which would impact `git fetch` doesn't have any effect on
>     +`git clone` at all.

This is not true, several such configuration variables work even during cloning, see:

  http://public-inbox.org/git/CAM0VKjkSMnemwPbFihXiQui3wm_wYmQeQmgYrFs5bfsH1jMg1A@mail.gmail.com/