Re: [PATCHv3 1/4] clone: respect additional configured fetch refspecs during initial fetch
- From
Jeff King <peff@peff.net>
- Date
- May 30, 2017, 03:55 UTC
- Message-ID
- <20170530035530.s2uqeityyhrdp5sx@sigill.intra.peff.net>
- In-Reply-To
- <xmqq8tlfdmpg.fsf@gitster.mtv.corp.google.com>
On Tue, May 30, 2017 at 12:53:47PM +0900, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Fri, May 26, 2017 at 12:04:03PM +0200, SZEDER Gábor wrote: > > > >> Unfortunately, putting the default refspec into this temporary > >> configuration environment breaks a few submodule tests > >> (t5614-clone-submodules or t5614-clone-submodules-shallow (it's got > >> renamed between this topic and master), t7407-submodule-foreach, > >> t7410-submodule-checkout-to), because it "leaks" to the submodule > >> environment. > > > > Doh, of course. I didn't think of that. That's probably a bad direction, > > then, as there's no "just for this process" global config. > > Yuck, right. So... do we have a further plan for this topic, or are > the patches more or less good as they are?
I was hoping we'd see one more iteration with the abstracted function for adding to the "struct remote". Gábor, let me know if you're too sick of the topic, and I can try to re-spin it.
-Peff