Re: [PATCH 2/2] travis-ci: record and skip successfully built trees
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Dec 29, 2017, 20:16 UTC
- Message-ID
- <CAM0VKjkL4VtbxspGFuQHfzVbch5tR_vY8hzHv4r7pdB9xJ3LBQ@mail.gmail.com>
- In-Reply-To
- <CAM0VKjk+LtW4dCuwsZ8ffXrN4HGL=ZC1budCOd53_w-20gwNag@mail.gmail.com>
On Fri, Dec 29, 2017 at 9:03 PM, SZEDER Gábor <szeder.dev@gmail.com> wrote:
Show 14 quoted lines
>>>> Or print it in a different color? Maybe red? >>>> >>>> See: https://travis-ci.org/szeder/git/jobs/322247836#L622-L625 >>> >>> I considered using color for the first line, but then didn't do it, >>> because I didn't want to decide the color :) >>> Anyway, red is the general error/failure color, but this is neither. It >>> could either be green, to match the color of the build job's result, or >>> something neutral like blue or yellow. >> >> You are right about red. I think I like yellow to express "warning". >> But this is just a nit. > > OK, yellow it will be then.
Oh, hang on! Have a look:
https://travis-ci.org/szeder/git/jobs/322841285#L629
That yellow is barely different from default text color. Bold stands out much better, but notice how Travis CI uses bold for all its messages. Therefore I think we should not use bold and leave it exclusive to Travis CI's messages.
Green looks good:
https://travis-ci.org/szeder/git/jobs/322372326#L629
Gábor