Re: [PATCHv2 0/3] Travis CI: skip commits with successfully built and tested trees
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Dec 31, 2017, 11:27 UTC
- Message-ID
- <1A70B41A-92D5-48D4-8550-86F56C4DF74F@gmail.com>
- In-Reply-To
- <20171231101205.7466-1-szeder.dev@gmail.com>
Show 22 quoted lines
> On 31 Dec 2017, at 11:12, SZEDER Gábor <szeder.dev@gmail.com> wrote: > > This is the second iteration of 'sg/travis-skip-identical-test', > addressing the comments of Lars and Jonathan: > > - Colorize the "Tip of $TRAVIS_BRANCH is exactly at $TAG" message > in the new patch 1/3. > > - Create the cache directory at the beginning of the build process > (patch 2/3). > > - Limit the the cached good trees file size to 1000 records, to > prevent it from growing too large for git/git's forever living > integration branches (patch 3/3). > > - Colorize the first line of the "skip build job because this tree has > been tested". Green it is (3/3). > > - Removed stray whitespace (3/3). > > - Updated an in-code comment, to make clear which code path deals with > a non-existing good trees file (3/3).
This series looks good to me. Nice work!
- Lars