git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Makefile: Improve compiler header dependency check

From
Fredrik Kuivinen <frekui@gmail.com>
Date
Aug 28, 2011, 11:47 UTC
Message-ID
<CALx8hKTx3r=ow+=jsCyvZGRJ6Yr+w9TT7=Uyi4y4+beOou45AA@mail.gmail.com>
In-Reply-To
<1314478844-55379-1-git-send-email-davvid@gmail.com>
On Sat, Aug 27, 2011 at 23:00, David Aguilar <davvid@gmail.com> wrote:
> Make the check use the same flags as the invocation to avoid
> false positives when user-configured compiler flags contain
> incompatible options.
[...]
> I'm not sure if "sh -c" is necessary but I did notice that other
> parts of the Makefile use $(SHELL_PATH).  The check was adjusted
> to use that as well.
I'm not sure either. I just used what I saw at other places in the Makefile.
[patch snipped]
Looks good to me. Thanks!
- Fredrik
Previous: David AguilarNext: Jonathan Nieder
Message 4 of 9 in “Makefile: Improve compiler header dependency check”
  1. Makefile: Improve compiler header dependency checkDavid Aguilar, Aug 27, 2011
  2. Jonathan NiederAug 27, 2011
  3. Makefile: Improve compiler header dependency checkDavid Aguilar, Aug 27, 2011
  4. Fredrik KuivinenAug 28, 2011
  5. Jonathan NiederAug 30, 2011
  6. Makefile: Improve compiler header dependency checkDavid Aguilar, Aug 30, 2011
  7. Jonathan NiederAug 30, 2011
  8. Junio C HamanoAug 30, 2011
  9. David AguilarAug 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.