From: Fredrik Kuivinen <frekui@gmail.com>
Date: Sun, 28 Aug 2011 11:47:46 GMT
Subject: Re: [PATCH v2] Makefile: Improve compiler header dependency check
Message-ID: <CALx8hKTx3r=ow+=jsCyvZGRJ6Yr+w9TT7=Uyi4y4+beOou45AA@mail.gmail.com>
In-Reply-To: <1314478844-55379-1-git-send-email-davvid@gmail.com>

On Sat, Aug 27, 2011 at 23:00, David Aguilar <davvid@gmail.com> wrote:
> Make the check use the same flags as the invocation to avoid
> false positives when user-configured compiler flags contain
> incompatible options.

[...]

> I'm not sure if "sh -c" is necessary but I did notice that other
> parts of the Makefile use $(SHELL_PATH).  The check was adjusted
> to use that as well.

I'm not sure either. I just used what I saw at other places in the Makefile.

[patch snipped]

Looks good to me. Thanks!

- Fredrik