git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] Teach git-stash to use --index from config

From
D. Ben Knoble <ben.knoble+github@gmail.com>
Date
Sep 16, 2025, 17:06 UTC
Message-ID
<CALnO6CCpcy2E4Q4u3+fVTtb3iNOCPUx2fdL+Lgd-+vWhptK2EQ@mail.gmail.com>
In-Reply-To
<4736597d-1144-43ce-8c09-e78e4563765b@gmail.com>
On Tue, Sep 16, 2025 at 5:25 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
Show 18 quoted lines
>
> Hi Ben
>
> On 16/09/2025 01:37, D. Ben Knoble wrote:
> >
> > PS I've left some new t3903 tests as copy-pasta for now to get feedback
> > on the rest of the series; there are bits of that file that could use an
> > update to the modern style (e.g., not using "test 1 = $(cat file)").
> > Since some new tests are substantially similar to old tests that use
> > this style, such cleanup is /probably/ warranted but will delay eyeballs
> > on the core of this series.
>
> In situations like this even if we don't convert the old tests, I think
> it is worth using a modern style for the new ones. Some people argue
> that the style within a file should be consistent but in practice that
> means if someone decides to clean them up in the future they have even
> more work to do and in the meantime we have a harder time debugging test
> failures.

Agreed—with Junio's "mostly good" downthread, I'll work on a v3 which _at least_ does the right thing for new tests. No promises on the old ones…

>
> The cleanups in patches 1 and 2 look very welcome. I've left a comment
> about the tests on patch 4.
Thanks, will look.
Previous: Phillip WoodNext: Junio C Hamano
Message 22 of 38 in “make stash apply with --index by default”
  1. 0/9 make stash apply with --index by defaultD. Ben Knoble, May 10, 2025
  2. 1/9 t3903: reduce dependencies on previous testsD. Ben Knoble, May 10, 2025
  3. 2/9 t3905: remove unneeded blank lineD. Ben Knoble, May 10, 2025
  4. 3/9 BreakingChanges: announce stash {apply,pop} will imply --indexD. Ben Knoble, May 10, 2025
  5. 4/9 stash: restore the index by default when breaking changes are enabledD. Ben Knoble, May 10, 2025
  6. 5/9 t0450: mark stash documentation as a known discrepancyD. Ben Knoble, May 10, 2025
  7. 6/9 t3903: adjust stash test to account for --[no-]index with breaking changesD. Ben Knoble, May 10, 2025
  8. 7/9 t3904: adjust stash -p test to account for index states with breaking changesD. Ben Knoble, May 10, 2025
  9. 8/9 t3905: adjust stash -u tests for breaking changesD. Ben Knoble, May 10, 2025
  10. 9/9 t3906: adjust stash submodule tests to account for breaking changesD. Ben Knoble, May 10, 2025
  11. Junio C HamanoMay 12, 2025
  12. D. Ben KnobleMay 20, 2025
  13. D. Ben KnobleMay 20, 2025
  14. 0/4 Teach git-stash to use --index from configD. Ben Knoble, Sep 16, 2025
  15. 1/4 t3903: reduce dependencies on previous testsD. Ben Knoble, Sep 16, 2025
  16. 2/4 t3905: remove unneeded blank lineD. Ben Knoble, Sep 16, 2025
  17. 3/4 stash: refactor private config globalsD. Ben Knoble, Sep 16, 2025
  18. 4/4 stash: honor stash.index in apply, pop modesD. Ben Knoble, Sep 16, 2025
  19. Phillip WoodSep 16, 2025
  20. D. Ben KnobleSep 16, 2025
  21. Phillip WoodSep 16, 2025
  22. D. Ben KnobleSep 16, 2025
  23. Junio C HamanoSep 16, 2025
  24. 0/4 Teach git-stash to use --index from configD. Ben Knoble, Sep 22, 2025
  25. 1/4 t3903: reduce dependencies on previous testsD. Ben Knoble, Sep 22, 2025
  26. 2/4 t3905: remove unneeded blank lineD. Ben Knoble, Sep 22, 2025
  27. 3/4 stash: refactor private config globalsD. Ben Knoble, Sep 22, 2025
  28. 4/4 stash: honor stash.index in apply, pop modesD. Ben Knoble, Sep 22, 2025
  29. Phillip WoodSep 22, 2025
  30. D. Ben KnobleSep 24, 2025
  31. Phillip WoodSep 29, 2025
  32. doc: explain the impact of stash.index on --autostash optionsD. Ben Knoble, Oct 6, 2025
  33. Kristoffer HaugsbakkOct 9, 2025
  34. D. Ben KnobleOct 11, 2025
  35. Junio C HamanoOct 11, 2025
  36. Ben KnobleOct 12, 2025
  37. Kristoffer HaugsbakkOct 13, 2025
  38. D. Ben KnobleOct 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.