From: D. Ben Knoble <ben.knoble+github@gmail.com>
Date: Tue, 16 Sep 2025 17:06:29 GMT
Subject: Re: [PATCH v2 0/4] Teach git-stash to use --index from config
Message-ID: <CALnO6CCpcy2E4Q4u3+fVTtb3iNOCPUx2fdL+Lgd-+vWhptK2EQ@mail.gmail.com>
In-Reply-To: <4736597d-1144-43ce-8c09-e78e4563765b@gmail.com>

On Tue, Sep 16, 2025 at 5:25 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> Hi Ben
>
> On 16/09/2025 01:37, D. Ben Knoble wrote:
> >
> > PS I've left some new t3903 tests as copy-pasta for now to get feedback
> > on the rest of the series; there are bits of that file that could use an
> > update to the modern style (e.g., not using "test 1 = $(cat file)").
> > Since some new tests are substantially similar to old tests that use
> > this style, such cleanup is /probably/ warranted but will delay eyeballs
> > on the core of this series.
>
> In situations like this even if we don't convert the old tests, I think
> it is worth using a modern style for the new ones. Some people argue
> that the style within a file should be consistent but in practice that
> means if someone decides to clean them up in the future they have even
> more work to do and in the meantime we have a harder time debugging test
> failures.

Agreed—with Junio's "mostly good" downthread, I'll work on a v3 which
_at least_ does the right thing for new tests. No promises on the old
ones…

>
> The cleanups in patches 1 and 2 look very welcome. I've left a comment
> about the tests on patch 4.

Thanks, will look.