git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] am: handle stray $dotest directory

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 15, 2013, 12:35 UTC
Message-ID
<CALkWK0nRtrvd=oX04XfqovYg1dnx3h+aNSNWH6MXnssOBqz=xw@mail.gmail.com>
In-Reply-To
<7vbo78o6ut.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I _think_ the new check you added may be too loose.

Yep, I totally forgot about the case when git-am.sh is called from an existing script. In that case, it is upto the caller to handle whatever stray directories; we have no business meddling with that.

> A fix-up may look like this.
No, don't leak autostash detail.
Just change that condition to
  if test -d "$dotest" && test -z "$rebasing"
and we're done.  I'll send in a re-roll.
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 16 in “Fix am with stray $dotest directory”
  1. 0/2 Fix am with stray $dotest directoryRamkumar Ramachandra, Jun 14, 2013
  2. 1/2 am: handle stray $dotest directoryRamkumar Ramachandra, Jun 14, 2013
  3. Junio C HamanoJun 14, 2013
  4. Ramkumar RamachandraJun 14, 2013
  5. Ramkumar RamachandraJun 16, 2013
  6. Junio C HamanoJun 14, 2013
  7. Ramkumar RamachandraJun 14, 2013
  8. Junio C HamanoJun 14, 2013
  9. Junio C HamanoJun 14, 2013
  10. Ramkumar RamachandraJun 15, 2013
  11. Junio C HamanoJun 14, 2013
  12. Ramkumar RamachandraJun 14, 2013
  13. Junio C HamanoJun 14, 2013
  14. Ramkumar RamachandraJun 14, 2013
  15. Junio C HamanoJun 14, 2013
  16. 2/2 t/am: use test_path_is_missing() where appropriateRamkumar Ramachandra, Jun 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.