git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] am: handle stray $dotest directory

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 14, 2013, 15:19 UTC
Message-ID
<7v1u84ra77.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CALkWK0m6r4yRfCLb3dejdY+1KJgdOHPfrvPXbftNucApXFx+0A@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Junio C Hamano wrote:
>> $dotest, or \$dotest?
>
> Works fine for me like this.  Why do we escape the dollar in the other strings?

The reason would become clear once you think what string you are feeding eval_gettext with if you do not escape. The translators translate a fixed string (possibly with placeholders) to a fixed translated string (possibly with placeholders).

	eval_gettext "Stray $dotest directory found. ..."

would allow the shell to expand $dotest before eval_gettext sees it, which would mean the string is no longer a constant.

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 13 of 16 in “Fix am with stray $dotest directory”
  1. 0/2 Fix am with stray $dotest directoryRamkumar Ramachandra, Jun 14, 2013
  2. 1/2 am: handle stray $dotest directoryRamkumar Ramachandra, Jun 14, 2013
  3. Junio C HamanoJun 14, 2013
  4. Ramkumar RamachandraJun 14, 2013
  5. Ramkumar RamachandraJun 16, 2013
  6. Junio C HamanoJun 14, 2013
  7. Ramkumar RamachandraJun 14, 2013
  8. Junio C HamanoJun 14, 2013
  9. Junio C HamanoJun 14, 2013
  10. Ramkumar RamachandraJun 15, 2013
  11. Junio C HamanoJun 14, 2013
  12. Ramkumar RamachandraJun 14, 2013
  13. Junio C HamanoJun 14, 2013
  14. Ramkumar RamachandraJun 14, 2013
  15. Junio C HamanoJun 14, 2013
  16. 2/2 t/am: use test_path_is_missing() where appropriateRamkumar Ramachandra, Jun 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.