git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/2] test-config: Add tests for the config_set API

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jul 6, 2014, 23:24 UTC
Message-ID
<CALkWK0n9MWux3tA02n-hDvPjXt3Q1RCVd+x8tJV9ABjndaGQCQ@mail.gmail.com>
In-Reply-To
<1404631162-18556-3-git-send-email-tanayabh@gmail.com>
A couple of quick nits.
Tanay Abhra wrote:
> +test_expect_success 'clear default config' '
> +       rm -f .git/config
> +'
Unnecessary; a fresh temporary directory is created for each test run.
> +test_expect_success 'initialize default config' '
You might want to mark this as "setup".
Previous: Matthieu MoyNext: Matthieu Moy
Message 8 of 9 in “git config cache & special querying api utilizing the cache”
  1. 0/3 git config cache & special querying api utilizing the cacheTanay Abhra, Jul 6, 2014
  2. 1/2 add `config_set` API for caching config-like filesTanay Abhra, Jul 6, 2014
  3. Ramsay JonesJul 6, 2014
  4. Matthieu MoyJul 6, 2014
  5. 2/2 test-config: Add tests for the config_set APITanay Abhra, Jul 6, 2014
  6. Matthieu MoyJul 6, 2014
  7. Matthieu MoyJul 6, 2014
  8. Ramkumar RamachandraJul 6, 2014
  9. Matthieu MoyJul 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.