From: Ramkumar Ramachandra Date: Sun, 06 Jul 2014 23:24:26 GMT Subject: Re: [PATCH v5 2/2] test-config: Add tests for the config_set API Message-ID: In-Reply-To: <1404631162-18556-3-git-send-email-tanayabh@gmail.com> A couple of quick nits. Tanay Abhra wrote: > +test_expect_success 'clear default config' ' > + rm -f .git/config > +' Unnecessary; a fresh temporary directory is created for each test run. > +test_expect_success 'initialize default config' ' You might want to mark this as "setup".