Re: [PATCH 1/3] for-each-ref: introduce %C(...) for color
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Nov 12, 2013, 03:38 UTC
- Message-ID
- <CALkWK0mz9PFce4F6xiDBeT+Cf=7Mihbb0fp9fa9WJJaMr5uH-g@mail.gmail.com>
- In-Reply-To
- <xmqqppqaol6w.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> $ git show -s --format='%CredAnd%CyellowAreNotTheSameColor'
Ouch, this is quite a disaster.
Show 8 quoted lines
> It would have been much saner if we started from %(color:yellow), > %(subject), etc., i.e. have a single long-hand magic introducer > %(...), and added a set of often-used short-hands like %s. > > I am not opposed to unify the internal implementations and the > external interfaces of pretty, for-each-ref and friends, but > modelling the external UI after the "mnemonic only with ad hoc > additions" mess the pretty-format uses is a huge mistake.
Okay, I'm convinced; I'll rework the series to do %(color:...) and resubmit shortly.
Thanks.