Re: [PATCH 1/3] for-each-ref: introduce %C(...) for color
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Nov 8, 2013, 12:14 UTC
- Message-ID
- <CALkWK0=w1G2O_W1LnfstqzaMjOQ0GWqJXeeRN4ymfsvohQBfyA@mail.gmail.com>
- In-Reply-To
- <xmqqvc045bvq.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> If %(authordate) is "I want to see the author date here", and > %(authordate:short) is "I want to see the author date here in the > short form", you would expect "I want colored output in green" to be > spelled as %(color:green), or something, perhaps?
Last time, we almost managed a unification: tokens like %authordate in f-e-r correspond to tokens like %ae in pretty-formats; %C(...) is different in that it doesn't actually output anything, but changes the color of tokens following it. While I'm not opposed to %(color:...), I would prefer a color syntax that is different from other-token syntax, like in pretty-formats.