Re: [PATCH 4/5] remote.c: teach branch_get() to treat symrefs other than HEAD

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 1, 2013, 20:57 UTC
Message-ID: <CALkWK0mz6+RS-fZAjz=1+kVN6WFTb+cX98V=8AGfzybacf28RQ@mail.gmail.com>
In-Reply-To: <CAMP44s1dWhpVhUar2-u1NAqK-TPssxZYgGMY9_SVxvuKSFT4QA@mail.gmail.com>

Felipe Contreras wrote:

> If you are arguing in favor of arbitrary symbolic refs plus @{u} to
> work, a patch that allows that, and nothing else, should make sense.
> Such patch would trigger further discussion, for example, if
> get_branch() is the right place to achieve that.

What kind of absurd argument is this? I am trying to solve the @ -> HEAD problem correctly. In the process, I fixed general symbolic-ref handling and cleaned up the @-parsing logic. Does anyone have a problem with the fix, or am I missing something?

So, start the discussion.  What are you waiting for?

> I still see this in the code:
>
>         if (!name || !*name || !strcmp(name, "HEAD"))

Remove the !strcmp(name, "HEAD") and tell me what you see. "HEAD" will get resolved just like any other symbolic ref, via the hunk I added.