Re: [PATCH 1/2] status: really ignore config with --porcelain

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jun 24, 2013, 16:53 UTC
Message-ID: <CALkWK0m5Q--G+KuNBoGdXphiBPnhcvMF2Jz+y4Rt0W2zx3m2KQ@mail.gmail.com>
In-Reply-To: <7vk3ljbh5r.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> In any case, I am still not convinced yet that status.short is a
> real problem if --porcelain readers trip with "## branchname"
> output.  Isn't it that the readers are broken and need fixing?

If you're going to read the configuration and then scramble to reset it in wt_porcelain_print(), why did you read the configuration in the first place? Should column.branch, status.submodulesummary, status.showuntrackedfiles affect the --porcelain output too? Isn't your expectation of my parser unreasonable?

I will argue that --porcelain should skip the branch config, and drop down one level lower directly: to the diff-ui configuration.