Re: [PATCH 1/2] status: really ignore config with --porcelain

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 28, 2013, 20:15 UTC
Message-ID: <7vzjuam1pu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130628193104.GA12625@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> Hmm. I would have thought --no-short would just set it to LONG. That is,
> we are no longer NONE at that point, as the user has told us something
> on the command line. So we are whatever --no-short is, which is LONG.
>
> But I guess that would wreck
>
>   git status --no-short -z
>
> which currently defaults to porcelain. Which, to be honest, seems a
> little crazy to me, but I guess there is no reason to break it.
>
> I am just trying to prevent the future maintenance confusion where a
> reader of the code says "Huh? What is the difference between NONE and
> UNSPECIFIED?"

Yeah, I share your sentiment, but I did not think of a better way to do this without unnecessarily changing behaviour.