git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] cherry-pick: make sure all input objects are commits

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Apr 11, 2013, 11:42 UTC
Message-ID
<CALkWK0kb+2KZLvRJDJb_VrNNs1k4grsfyFv0HfYv0Kr9v4sChQ@mail.gmail.com>
In-Reply-To
<20130411110324.GD12770@suse.cz>
Miklos Vajna wrote:
> I guess that is a should-not-happen category. parse_args() calls
> setup_revisions(), and that will already die() if the argument is not a
> valid object at all.

Then why do you have an if() guarding the code? In my opinion, you should have an else-clause that die()s with an appropriate message.

> Yes. If you would want, I could of course add test cases for two other
> cases when we already errored out and now the error message is just
> changed, but I don't think duplicating the error message strings from
> the code to the testsuite is really wanted. :-)

Nope, I'd never suggest that: this is fine. What I meant is: you should clarify that you're fixing a bug and adding a test to guard it, in the commit message.

Previous: Miklos VajnaNext: Miklos Vajna
Message 8 of 17 in “cherry-pick: better error message when the parameter is a non-commit”
  1. cherry-pick: better error message when the parameter is a non-commitMiklos Vajna, Apr 3, 2013
  2. Miklos VajnaApr 8, 2013
  3. Junio C HamanoApr 8, 2013
  4. Junio C HamanoApr 8, 2013
  5. cherry-pick: make sure all input objects are commitsMiklos Vajna, Apr 11, 2013
  6. Ramkumar RamachandraApr 11, 2013
  7. Miklos VajnaApr 11, 2013
  8. Ramkumar RamachandraApr 11, 2013
  9. cherry-pick: make sure all input objects are commitsMiklos Vajna, Apr 11, 2013
  10. Ramkumar RamachandraApr 11, 2013
  11. Thomas RastApr 15, 2013
  12. Junio C HamanoApr 15, 2013
  13. Junio C HamanoApr 15, 2013
  14. Michael HaggertyApr 16, 2013
  15. Junio C HamanoMay 9, 2013
  16. Junio C HamanoMay 9, 2013
  17. Miklos VajnaMay 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.