Re: [PATCH] cherry-pick: better error message when the parameter is a non-commit

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2013, 16:45 UTC
Message-ID: <7v7gkdynqx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130408122750.GB5132@suse.cz>

Miklos Vajna <vmiklos@suse.cz> writes:

Show 16 quoted lines

> On Wed, Apr 03, 2013 at 11:27:04AM +0200, Miklos Vajna <vmiklos@suse.cz> wrote:
>> When copy&paste goes wrong, and the user e.g. tries to cherry-pick a
>> blob, the error message used to be:
>> 
>> 	fatal: BUG: expected exactly one commit from walk
>> 
>> Instead, now it is:
>> 
>> 	fatal: Can't cherry-pick a blob
>> 
>> Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
>> ---
>>  sequencer.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> Ping, any comment on this patch?

Nothing in particular from me.