git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git_path() returns relative paths

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jul 27, 2013, 14:33 UTC
Message-ID
<CALkWK0kWnge7fVtTXRgTiK1NbyN8X=bmqfPTc+Mp=BCssPc1og@mail.gmail.com>
In-Reply-To
<CACsJy8C5Du8zcqVeN7EGuyUxgSZaRq-X8y_hQvqQedYWfP8p+A@mail.gmail.com>
Duy Nguyen wrote:
> 044bbbc (Make git_dir a path relative to work_tree in
> setup_work_tree() - 2008-06-19)

Okay, so it does seem to be a significant optimization. Frankly, e02ca72 only improves the relative_path() algorithm, and it's not really doing anything Wrong: it's has just uncovered a previously undiscovered bug.

So far, we know that the line:
  s->fp = fopen(git_path(commit_editmsg), "w");

in commit.c:prepare_to_commit() isn't failing; so, the work_tree and git_dir do seem to be set correctly. The problem seems to be in launch_editor(). What's worse? Everything works just fine when I have a symbolic link to a directory in a normal repository; I still can't figure out what submodules have to do with any of this.

What the hell is going on?!
Previous: Duy NguyenNext: Duy Nguyen
Message 6 of 18 in “[BUG] git_path() returns relative paths”
  1. Ramkumar RamachandraJul 27, 2013
  2. Duy NguyenJul 27, 2013
  3. Ramkumar RamachandraJul 27, 2013
  4. Ramkumar RamachandraJul 27, 2013
  5. Duy NguyenJul 27, 2013
  6. Ramkumar RamachandraJul 27, 2013
  7. Duy NguyenJul 27, 2013
  8. Ramkumar RamachandraJul 27, 2013
  9. Jiang XinJul 27, 2013
  10. Ramkumar RamachandraJul 28, 2013
  11. Duy NguyenJul 28, 2013
  12. Ramkumar RamachandraJul 28, 2013
  13. Duy NguyenJul 28, 2013
  14. Ramkumar RamachandraJul 28, 2013
  15. Duy NguyenJul 28, 2013
  16. Ramkumar RamachandraJul 28, 2013
  17. Fredrik GustafssonJul 27, 2013
  18. Ramkumar RamachandraJul 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.