Re: [BUG] git_path() returns relative paths

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 27, 2013, 12:47 UTC
Message-ID: <CACsJy8C5Du8zcqVeN7EGuyUxgSZaRq-X8y_hQvqQedYWfP8p+A@mail.gmail.com>
In-Reply-To: <CALkWK0kBesC2=kyygMCt61Fm5GGqX+yF6sbkCRcGYZ=ovgtTAQ@mail.gmail.com>

On Sat, Jul 27, 2013 at 7:31 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 12 quoted lines

> Ramkumar Ramachandra wrote:
>> e02ca72 (path.c: refactor relative_path(), not only strip prefix,
>> 2013-06-25) is the offender.
>
> The problem is the callsite in setup.c:setup_work_tree(). When
> relative_path() is called with
> "/home/artagnon/dotfiles/.git/modules/.elisp/flx" and
> "/home/artagnon/dotfiles/.elisp/flx" as the first and second
> arguments, it sets sb to "../../.git/modules/.elisp/flx".
>
> Makes me wonder why setup_git_dir() doesn't just use git_dir; why does
> it need a relative path at all?

044bbbc (Make git_dir a path relative to work_tree in setup_work_tree() - 2008-06-19)

-- 
Duy