Re: [RFC v2] reflog: show committer date in verbose mode
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 3, 2013, 10:00 UTC
- Message-ID
- <CALkWK0k-cikpwue4iQDGJgP4NrGdkCw2r=dzzP78+QbsA5BiMA@mail.gmail.com>
- In-Reply-To
- <517a09251fbbc81073fbd53f04a3f4b58cb8b3f7.1370224175.git.worldhello.net@gmail.com>
Jiang Xin wrote:
> It will be nice to add this pretty formatter automatically when run > `git reflog` in verbose mode. And in order to support verbose mode, add > new flag "verbose" in struct rev_info.
Sorry I missed earlier revisions of this patch. Generally speaking, "verbose" is a bad way to control format-specifiers. Why not add to the list of pretty-format specifiers (like oneline, short, medium, full)? Also, this patch is extremely pervasive in that it teaches a poorly defined "verbosity" to a very low layer: revision.c/revision.h.