Re: [RFC v2] reflog: show committer date in verbose mode

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2013, 17:43 UTC
Message-ID: <7v61xvgkeh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CANYiYbG-f+bM0jP0f-R-ciuR0sR13+8FcYkTas-X0LOh1mPRfg@mail.gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 15 quoted lines

> 2013/6/3 Ramkumar Ramachandra <artagnon@gmail.com>:
>> Jiang Xin wrote:
>>> It will be nice to add this pretty formatter automatically when run
>>> `git reflog` in verbose mode. And in order to support verbose mode, add
>>> new flag "verbose" in struct rev_info.
>>
>> Sorry I missed earlier revisions of this patch.  Generally speaking,
>> "verbose" is a bad way to control format-specifiers.  Why not add to
>> the list of pretty-format specifiers (like oneline, short, medium,
>> full)?  Also, this patch is extremely pervasive in that it teaches a
>> poorly defined "verbosity" to a very low layer: revision.c/revision.h.
>
> I also feel bad when adding new flag "verbose" into rev_info. = =b
>
> CommitDate is more significant than AuthorDate for reflog.

This is a curious statement, as I've seen it in a different context recently.

Is it committer date that you really care about, or are you using it as a substitute for something else you care more about, namely, the time of the event the reflog entry was created (i.e. when you committed, when you resetted, when you "branch -f"ed)?