Re: [PATCH 3/3] t4033-diff-patience: factor out tests
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jul 6, 2011, 07:29 UTC
- Message-ID
- <CALkWK0=qO4NOfK0x044Hd+dM5pY8-EMrBrk_Tkia=fpYDzkyig@mail.gmail.com>
- In-Reply-To
- <1309932945-5048-4-git-send-email-rctay89@gmail.com>
Hi Tay,
Tay Ray Chuan writes:
> ---
Submitting RFC patches without commit messages is alright I think, but a missing signoff won't even permit anyone else to pick up this up and work on it. Please sign-off on everything.
> t/lib-diff-patience.sh | 162 ++++++++++++++++++++++++++++++++++++++++++++++ > t/t4033-diff-patience.sh | 162 +--------------------------------------------- > 2 files changed, 165 insertions(+), 159 deletions(-) > create mode 100644 t/lib-diff-patience.sh
Maybe separate this out into two patches: one that renames the file, and another that makes the minor changes so that it's easy to review?
-- Ram