Re: [PATCH 3/3] t4033-diff-patience: factor out tests

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Jul 6, 2011, 15:01 UTC
Message-ID: <CALUzUxoOS69xR07eoYYjum5XBqAVuFgh9LkzKCV2X5J5_m3gZA@mail.gmail.com>
In-Reply-To: <CALkWK0=qO4NOfK0x044Hd+dM5pY8-EMrBrk_Tkia=fpYDzkyig@mail.gmail.com>

On Wed, Jul 6, 2011 at 3:29 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

> Submitting RFC patches without commit messages is alright I think, but
> a missing signoff won't even permit anyone else to pick up this up and
> work on it.  Please sign-off on everything.

Oops.

Show 7 quoted lines

>>  t/lib-diff-patience.sh   |  162 ++++++++++++++++++++++++++++++++++++++++++++++
>>  t/t4033-diff-patience.sh |  162 +---------------------------------------------
>>  2 files changed, 165 insertions(+), 159 deletions(-)
>>  create mode 100644 t/lib-diff-patience.sh
>
> Maybe separate this out into two patches: one that renames the file,
> and another that makes the minor changes so that it's easy to review?

Good idea.

-- 
Cheers,
Ray Chuan